dianaclarke commented on a change in pull request #9458:
URL: https://github.com/apache/arrow/pull/9458#discussion_r573277115
##########
File path: dev/archery/archery/benchmark/core.py
##########
@@ -27,11 +27,14 @@ def median(values):
class Benchmark:
- def __init__(self, name, unit, less_is_better, values, counters=None):
Review comment:
Manually tested this change with the following command.
`$ archery benchmark run
--suite-filter=arrow-compute-vector-selection-benchmark
--benchmark-filter=TakeStringRandomIndicesWithNulls --repetitions=3`
Output snippet:
```
{
"suites": [
{
"name": "arrow-compute-vector-selection-benchmark",
"benchmarks": [
{
"name": "TakeStringRandomIndicesWithNulls/262144/0",
"unit": "items_per_second",
"less_is_better": false,
"values": [
18536824.77866367,
19191618.243985265,
19796322.323237784
],
"time_unit": "ns",
"times": [
14596346.90588616,
14821237.647319557,
16059698.500342807
]
},
...
]
}
]
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
