pitrou commented on a change in pull request #9458:
URL: https://github.com/apache/arrow/pull/9458#discussion_r580961376
##########
File path: dev/archery/archery/utils/codec.py
##########
@@ -48,6 +48,8 @@ def encode(b):
"unit": b.unit,
"less_is_better": b.less_is_better,
"values": b.values,
+ "time_unit": b.time_unit,
Review comment:
I have no idea :-) Feel free to move it around if it's only used by
`archery.benchmark`.
##########
File path: dev/archery/archery/benchmark/core.py
##########
@@ -27,11 +27,14 @@ def median(values):
class Benchmark:
- def __init__(self, name, unit, less_is_better, values, counters=None):
Review comment:
Interesting. Did you check it works properly with a benchmark that only
outputs runtimes? One example is `arrow-memory-pool-benchmark`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
