dianaclarke commented on a change in pull request #9458:
URL: https://github.com/apache/arrow/pull/9458#discussion_r581212464
##########
File path: dev/archery/archery/benchmark/core.py
##########
@@ -27,11 +27,14 @@ def median(values):
class Benchmark:
- def __init__(self, name, unit, less_is_better, values, counters=None):
Review comment:
PS. If I fix the prefer real time check, I see the redundant results I
would expect for benchmarks ending in `/real_time`.
```
{
"name":
"AllocateDeallocate<Jemalloc>/size:1048576/real_time",
"unit": "ns",
"less_is_better": true,
"values": [
1669.6396259875594,
1681.1759457288072,
1689.4427232189955
],
"time_unit": "ns",
"times": [
1669.6396259875594,
1681.1759457288072,
1689.4427232189955
]
},
```
```
@property
def is_realtime(self):
""" Indicate if the preferred value is realtime instead of cputime.
"""
- return self.name.find("/realtime") != -1
+ return self.name.find("/real_time") != -1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
