dianaclarke commented on a change in pull request #9458:
URL: https://github.com/apache/arrow/pull/9458#discussion_r581177513
##########
File path: dev/archery/archery/benchmark/core.py
##########
@@ -27,11 +27,14 @@ def median(values):
class Benchmark:
- def __init__(self, name, unit, less_is_better, values, counters=None):
Review comment:
It will work fine, but it will be redundant.
That said, I just tested the suite you mentioned, and it looks like I've
found an unrelated bug.
I would have expected `times` to be equal to `values` here because the
benchmark name ends in `real_time` which is supposed to be a hint to prefer
`real_time` over `cpu_time`, but the check is using `/realtime"`, not
`/real_time"`.
I'lll create a different issue and pull request for that since it's
unrelated to this one.
```
@property
def is_realtime(self):
""" Indicate if the preferred value is realtime instead of cputime.
"""
return self.name.find("/realtime") != -1
```
```
{
"name":
"AllocateDeallocate<Jemalloc>/size:1048576/real_time",
"unit": "ns",
"less_is_better": true,
"values": [
1508.9095897178113,
1511.4170658339356,
1524.9203870819892
],
"time_unit": "ns",
"times": [
1513.748357015267,
1515.7354204676608,
1534.3125060644313
]
},
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
