lidavidm commented on code in PR #1649: URL: https://github.com/apache/arrow-adbc/pull/1649#discussion_r1550849147
########## adbc.h: ########## @@ -459,6 +459,28 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream /// /// \see AdbcConnectionGetInfo #define ADBC_INFO_VENDOR_ARROW_VERSION 2 +/// \brief Indicates whether the driver connection is read only (type: bool). +/// +/// \see AdbcConnectionGetInfo +#define ADBC_INFO_VENDOR_READ_ONLY 3 Review Comment: Hmm. Should this be an actual option (GetOption/SetOption), since it in principle is mutable in other APIs? e.g. [JDBC `Connection#setReadOnly`](https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#setReadOnly-boolean-). Flight SQL of course doesn't let you set this, but it may apply to other things in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
