comphead commented on code in PR #10031:
URL:
https://github.com/apache/arrow-datafusion/pull/10031#discussion_r1561191543
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -415,6 +415,18 @@ impl PartialEq<dyn Any> for InListExpr {
}
}
+/// Checks if two types are logically equal, dictionary types are compared by
their value types.
+fn is_logically_eq(lhs: &DataType, rhs: &DataType) -> bool {
Review Comment:
hm, I think we have a similar method in
https://github.com/apache/arrow-datafusion/blob/f55c1d90215614ce531a4103c7dbebf318de1cfd/datafusion/common/src/dfschema.rs#L643
basically the schema struct has a lot of equal checks between datatypes. may
want to move them into separate utils struct as they mostly working with
datatypes rather than schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
