alamb commented on code in PR #10031:
URL:
https://github.com/apache/arrow-datafusion/pull/10031#discussion_r1561517227
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -415,6 +415,18 @@ impl PartialEq<dyn Any> for InListExpr {
}
}
+/// Checks if two types are logically equal, dictionary types are compared by
their value types.
+fn is_logically_eq(lhs: &DataType, rhs: &DataType) -> bool {
Review Comment:
I agree we could use `datatype_is_logically_equal` instead here. It also
seems like a good idea to make that function more discoverable -- I also think
it would be fine to do as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
