advancedxy commented on PR #10031: URL: https://github.com/apache/arrow-datafusion/pull/10031#issuecomment-2050862808
> The tests still pass 🤔 > I worry that this means we might break this feature in the future but not know... Nice catch, and thanks for your careful review. I think the problem is that we cast exprs to match each other's types in test. I update the related test code in https://github.com/apache/arrow-datafusion/pull/10031/commits/07a95b7618f243ac83f21f161fd6f68f18a541db. Do that look good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
