advancedxy commented on PR #10031: URL: https://github.com/apache/arrow-datafusion/pull/10031#issuecomment-2053648310
> Thanks @advancedxy -- I still think there is something not right about this PR > > I don't think this PR will change any external behavior (see my comments) > > Also the `sqllogictest`s still pass without the code change > > I am beginning to wonder if we really understand the problem or not. > > I would suggest starting at this problem from the other end -- can we write a test that causes the error seen in comet (aka do whatever comet is doing). Once we have that then we can change to code to fix it Thanks for your feedback and suggestions. I replied to your comments, which I think should explain your concerns and the current test in this PR should already do what Comet is trying to do. Please let me know if you have any further questions ior concerns. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
