Tom-Newton commented on code in PR #41276:
URL: https://github.com/apache/arrow/pull/41276#discussion_r1571438084
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -381,6 +388,24 @@ AzureOptions::MakeDataLakeServiceClient() const {
return Status::Invalid("AzureOptions doesn't contain a valid auth
configuration");
}
+Result<std::string> AzureOptions::GenerateSASToken(
+ Storage::Sas::BlobSasBuilder* builder) const {
+ if (storage_shared_key_credential_) {
+ return builder->GenerateSasToken(*storage_shared_key_credential_);
+ } else {
+ // This part isn't tested. This may not work.
Review Comment:
Sorry I misunderstood the intention (I haven't found time to review this).
Configuring other auths in testing might be a bit difficult. For Azurite I
think the first challenge is configuring `https`, which I have struggled with
before. Beyond that I think there are 2 viable options offered by Azure:
1. Service principal
1. Username and password for a service account
2. Surprisingly complicated to create
1. Azure CLI
1. Authenticates as your user
2. Requires installing the Azure CLI and running `az login`, then
completing the login in your browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
