kou commented on code in PR #41276:
URL: https://github.com/apache/arrow/pull/41276#discussion_r1573578375


##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -381,6 +388,24 @@ AzureOptions::MakeDataLakeServiceClient() const {
   return Status::Invalid("AzureOptions doesn't contain a valid auth 
configuration");
 }
 
+Result<std::string> AzureOptions::GenerateSASToken(
+    Storage::Sas::BlobSasBuilder* builder) const {
+  if (storage_shared_key_credential_) {
+    return builder->GenerateSasToken(*storage_shared_key_credential_);
+  } else {
+    // This part isn't tested. This may not work.

Review Comment:
   Thanks.
   I tried `az login` and `ConfigureDefaultCredential()` but some operations 
such as `CreateDir()` was blocked...
   It seems that we need to implement GH-39344 to test this part.
   
   I'll open a new issue for this part and defer this part in this PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to