felipecrv commented on code in PR #41276:
URL: https://github.com/apache/arrow/pull/41276#discussion_r1572597451


##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -2868,8 +2886,19 @@ class AzureFileSystem::Impl {
     if (src == dest) {
       return Status::OK();
     }
+    std::string sas_token;
+    {
+      Storage::Sas::BlobSasBuilder builder;
+      std::chrono::seconds available_period(60);
+      builder.ExpiresOn = std::chrono::system_clock::now() + available_period;
+      builder.BlobContainerName = src.container;
+      builder.BlobName = src.path;
+      builder.Resource = Storage::Sas::BlobSasResource::Blob;
+      builder.SetPermissions(Storage::Sas::BlobSasPermissions::Read);
+      ARROW_ASSIGN_OR_RAISE(sas_token, options_.GenerateSASToken(&builder));
+    }
+    auto src_url = GetBlobClient(src.container, src.path).GetUrl() + sas_token;

Review Comment:
   Ok. It comes with the `?` already.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to