Tom-Newton commented on code in PR #41276:
URL: https://github.com/apache/arrow/pull/41276#discussion_r1573734719
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -381,6 +388,24 @@ AzureOptions::MakeDataLakeServiceClient() const {
return Status::Invalid("AzureOptions doesn't contain a valid auth
configuration");
}
+Result<std::string> AzureOptions::GenerateSASToken(
+ Storage::Sas::BlobSasBuilder* builder) const {
+ if (storage_shared_key_credential_) {
+ return builder->GenerateSasToken(*storage_shared_key_credential_);
+ } else {
+ // This part isn't tested. This may not work.
Review Comment:
> I tried az login and ConfigureDefaultCredential() but some operations such
as CreateDir() was blocked...
It seems that we need to implement
https://github.com/apache/arrow/issues/39344 to test this part.
This seems a bit suspicious. Default credential does include CLI auth...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
