joemarshall commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1574511165
##########
python/CMakeLists.txt:
##########
@@ -590,28 +616,42 @@ endif()
# Acero
if(PYARROW_BUILD_ACERO)
- if(PYARROW_BUNDLE_ARROW_CPP)
- bundle_arrow_lib(${ARROW_ACERO_SHARED_LIB} SO_VERSION ${ARROW_SO_VERSION})
- if(MSVC)
- bundle_arrow_import_lib(${ARROW_ACERO_IMPORT_LIB})
+ if(ARROW_BUILD_SHARED)
+
+ if(PYARROW_BUNDLE_ARROW_CPP)
+ bundle_arrow_lib(${ARROW_ACERO_SHARED_LIB} SO_VERSION
${ARROW_SO_VERSION})
+ if(MSVC)
+ bundle_arrow_import_lib(${ARROW_ACERO_IMPORT_LIB})
+ endif()
endif()
- endif()
- set(ACERO_LINK_LIBS ArrowAcero::arrow_acero_shared)
- list(APPEND CYTHON_EXTENSIONS _acero)
+ set(ACERO_LINK_LIBS ArrowAcero::arrow_acero_shared)
+ list(APPEND CYTHON_EXTENSIONS _acero)
+ else()
+ # ACERO is statically linked into libarrow_python already
+ set(ACERO_LINK_LIBS)
Review Comment:
If we do that, then we have libarrow_acero included in libarrow_python.so
and also in _acero.so and bad things happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
