joemarshall commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1574602705
##########
python/CMakeLists.txt:
##########
@@ -763,8 +813,12 @@ foreach(module ${CYTHON_EXTENSIONS})
set_target_properties(${module_name} PROPERTIES COMPILE_DEFINITIONS
"CYTHON_TRACE=1;CYTHON_TRACE_NOGIL=1")
endif()
-
- target_link_libraries(${module_name} PRIVATE ${LINK_LIBS})
+ # user this rather roundabout way of including, otherwise the
+ # in static linking mode the target will depend on libarrow and
+ # build it into every cython extension
+ target_include_directories(${module_name} PUBLIC
$<TARGET_PROPERTY:arrow_python,INTERFACE_INCLUDE_DIRECTORIES>)
+ target_link_libraries(${module_name} PUBLIC $<TARGET_FILE:arrow_python>)
+ add_dependencies(${module_name} arrow_python)
Review Comment:
Ah, hang on, if I make only ARROW_CPP_LINK_LIBS private, I think it works
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
