kou commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1575363633
##########
cpp/src/arrow/acero/CMakeLists.txt:
##########
@@ -173,13 +173,8 @@ add_arrow_acero_test(hash_join_node_test SOURCES
hash_join_node_test.cc
bloom_filter_test.cc)
add_arrow_acero_test(pivot_longer_node_test SOURCES pivot_longer_node_test.cc)
-# asof_join_node and sorted_merge_node use std::thread internally
-# and doesn't use ThreadPool so it will
-# be broken if threading is turned off
-if(ARROW_ENABLE_THREADING)
- add_arrow_acero_test(asof_join_node_test SOURCES asof_join_node_test.cc)
- add_arrow_acero_test(sorted_merge_node_test SOURCES
sorted_merge_node_test.cc)
-endif()
+add_arrow_acero_test(asof_join_node_test SOURCES asof_join_node_test.cc)
+add_arrow_acero_test(sorted_merge_node_test SOURCES sorted_merge_node_test.cc)
Review Comment:
It seems that this change is #41125. Let's work on #41125 before this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
