felipecrv commented on code in PR #41575: URL: https://github.com/apache/arrow/pull/41575#discussion_r1592919261
########## cpp/src/arrow/testing/fixed_width_test_util.h: ########## @@ -17,16 +17,6 @@ #pragma once -#include <cstddef> -#include <cstdint> -#include <memory> -#include <vector> - -#include "arrow/array/builder_primitive.h" -#include "arrow/builder.h" -#include "arrow/type.h" -#include "arrow/util/checked_cast.h" - Review Comment: I meant reducing the code in the header. We should keep the necessary includes. The class should only declare the public function members here and all the private members and template code can be defined in the `.cc` file (to be created) outside of the class. See how `chunk_resolver.h/cc` does it reducing the bloat in the header: https://github.com/apache/arrow/blob/51689a040cbe3dee8702cd899a33fa62e0616bf1/cpp/src/arrow/chunk_resolver.cc#L44-L45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
