llama90 commented on PR #41575: URL: https://github.com/apache/arrow/pull/41575#issuecomment-2112355452
@felipecrv Hello, and thank you for your review. I have applied the changes as advised, but I am a bit unsure about one aspect, particularly because I am not very familiar with template functions. Should the `VisitAllNestedListConfigurations` template function also be moved to an anonymous namespace? It is directly called from the test function (`vector_selection_test.cc`), so I have kept it as it currently is. Additionally, I made modifications to the `Makefile` to accommodate the Windows CI process. Could you please confirm if this approach is correct? I would greatly appreciate your advice on these matters. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
