llama90 commented on code in PR #41575: URL: https://github.com/apache/arrow/pull/41575#discussion_r1593351811
########## cpp/src/arrow/testing/fixed_width_test_util.h: ########## @@ -17,16 +17,6 @@ #pragma once -#include <cstddef> -#include <cstdint> -#include <memory> -#include <vector> - -#include "arrow/array/builder_primitive.h" -#include "arrow/builder.h" -#include "arrow/type.h" -#include "arrow/util/checked_cast.h" - Review Comment: Ah, so I need to organize the code according to C++ conventions. I should include only the declarations in the .h file and put the implementations in the .cc file. I will refer to the code you shared, organize it accordingly, and then upload it. Thank you for your guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
