felipecrv commented on code in PR #41575:
URL: https://github.com/apache/arrow/pull/41575#discussion_r1600636364
##########
cpp/src/arrow/testing/fixed_width_test_util.h:
##########
@@ -120,84 +170,6 @@ class NestedListGenerator {
}
return nested_builder->Finish();
}
-
Review Comment:
You should have the definition of `NestedListArray` in the `.cc` as well.
##########
cpp/src/arrow/testing/fixed_width_test_util.h:
##########
@@ -35,24 +29,80 @@ class NestedListGenerator {
///
/// \return `fixed_size_list(fixed_size_list(..., sizes[1]), sizes[0])`
static std::shared_ptr<DataType> NestedFSLType(
- const std::shared_ptr<DataType>& inner_type, const std::vector<int>&
sizes) {
- auto type = inner_type;
- for (auto it = sizes.rbegin(); it != sizes.rend(); it++) {
- type = fixed_size_list(std::move(type), *it);
- }
- return type;
- }
+ const std::shared_ptr<DataType>& inner_type, const std::vector<int>&
sizes);
/// \brief Create a nested FixedListType.
Review Comment:
You should move these template functions to an anonymous namespace in the
`.cc` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
