tscottcoombes1 commented on code in PR #40496:
URL: https://github.com/apache/arrow/pull/40496#discussion_r1596652338
##########
go/arrow/array/dictionary.go:
##########
@@ -672,7 +672,7 @@ func NewDictionaryBuilderWithDict(mem memory.Allocator, dt
*arrow.DictionaryType
}
func NewDictionaryBuilder(mem memory.Allocator, dt *arrow.DictionaryType)
DictionaryBuilder {
- return NewDictionaryBuilderWithDict(mem, dt, nil)
+ return NewDictionaryBuilderWithDict(mem, dt, dt.Values)
Review Comment:
@zeroshade I've left my safe world of util/protobuf_reflect here.
For handling the enums, where we know all the values in advance, we can
buildWithDict. But the array needed to be somewhere. I think here was the least
disruptive place to put it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
