zeroshade commented on code in PR #40496:
URL: https://github.com/apache/arrow/pull/40496#discussion_r1597012038
##########
go/arrow/array/dictionary.go:
##########
@@ -672,7 +672,7 @@ func NewDictionaryBuilderWithDict(mem memory.Allocator, dt
*arrow.DictionaryType
}
func NewDictionaryBuilder(mem memory.Allocator, dt *arrow.DictionaryType)
DictionaryBuilder {
- return NewDictionaryBuilderWithDict(mem, dt, nil)
+ return NewDictionaryBuilderWithDict(mem, dt, dt.Values)
Review Comment:
This isn't a viable solution unfortunately. The dictionary values should not
be tied to the dictionary data type at all. You need to explicitly handle
holding onto the values internally to the protobuf reflect code and call
`NewDictionaryBuilderWithDict` yourself from there. We can't propagate the
values in the `DictionaryType` struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
