alamb commented on code in PR #6269:
URL: https://github.com/apache/arrow-rs/pull/6269#discussion_r1734498878
##########
parquet_derive_test/src/lib.rs:
##########
@@ -70,12 +70,12 @@ struct APartiallyCompleteRecord {
// If these fields are guaranteed to be valid
// we can load this struct into APartiallyCompleteRecord
#[derive(PartialEq, ParquetRecordWriter, Debug)]
-struct APartiallyOptionalRecord {
+struct AnOptionalRecord {
Review Comment:
Why did you rename this structure and the fields? It seems like the original
name `APartiallyOptionalRecord` is more accurate and the names of the fields
are more specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
