double-free commented on code in PR #6269:
URL: https://github.com/apache/arrow-rs/pull/6269#discussion_r1735024495
##########
parquet_derive/src/lib.rs:
##########
@@ -206,6 +205,12 @@ pub fn parquet_record_reader(input:
proc_macro::TokenStream) -> proc_macro::Toke
let mut row_group_reader = row_group_reader;
+ // key: parquet file column name, value: column index
+ let mut name_to_index = std::collections::HashMap::new();
Review Comment:
Yes, agree this is fine for now. As said in the document:
> This does not generate readers or writers for arbitrarily nested
structures.
This solution is reasonable under this constraint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
