double-free commented on code in PR #6269:
URL: https://github.com/apache/arrow-rs/pull/6269#discussion_r1735030673
##########
parquet_derive_test/src/lib.rs:
##########
@@ -70,12 +70,12 @@ struct APartiallyCompleteRecord {
// If these fields are guaranteed to be valid
// we can load this struct into APartiallyCompleteRecord
#[derive(PartialEq, ParquetRecordWriter, Debug)]
-struct APartiallyOptionalRecord {
+struct AnOptionalRecord {
Review Comment:
yes, I will restore the struct's name, but the field names must be changed.
This is because the fact that now the columns are matched with field name (not
index, as previous), so the constraint is:
> the decoded struct must have consistent field name with the column name in
parquet
Given that the struct are written by `APartiallyCompleteRecord`, `maybe_i16`
should be renamed back to `i16`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
