alamb commented on code in PR #6269:
URL: https://github.com/apache/arrow-rs/pull/6269#discussion_r1734502786
##########
parquet_derive/src/lib.rs:
##########
@@ -206,6 +205,12 @@ pub fn parquet_record_reader(input:
proc_macro::TokenStream) -> proc_macro::Toke
let mut row_group_reader = row_group_reader;
+ // key: parquet file column name, value: column index
+ let mut name_to_index = std::collections::HashMap::new();
Review Comment:
I am not sure this strategy will work for nested structures. However, given
all the tests pass we likely don't have coverage for such structures so I am
not sure the existing code would work for it either.
Thus I think this is fine for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
