zeroshade commented on code in PR #43957: URL: https://github.com/apache/arrow/pull/43957#discussion_r1752151777
########## cpp/src/arrow/compute/kernels/codegen_internal.h: ########## @@ -224,7 +258,9 @@ using enable_if_not_floating_value = enable_if_t<!std::is_floating_point<T>::val template <typename T, typename R = T> using enable_if_decimal_value = - enable_if_t<std::is_same<Decimal128, T>::value || std::is_same<Decimal256, T>::value, + enable_if_t<std::is_same<Decimal32, T>::value || std::is_same<Decimal64, T>::value || + std::is_same<Decimal128, T>::value || + std::is_same<Decimal256, T>::value, Review Comment: That was my thought too, we just need to make sure we call it out in the changelog to ensure anyone who reads the changelog that was relying on code like that would be aware. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
