zeroshade commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1752268424
##########
cpp/src/arrow/compute/kernels/codegen_internal.h:
##########
@@ -140,6 +140,30 @@ struct GetViewType<Type,
enable_if_t<is_base_binary_type<Type>::value ||
static T LogicalValue(PhysicalType value) { return value; }
};
+template <>
+struct GetViewType<Decimal32Type> {
+ using T = Decimal32;
+ using PhysicalType = std::string_view;
Review Comment:
The issue comes down to `visit_data_inline.h` which uses `std::string_view`
to call these `GetViewType` functions, so I don't think we could replace these
`std::string_view` usages without significant refactors elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
