lidavidm commented on code in PR #43632:
URL: https://github.com/apache/arrow/pull/43632#discussion_r1830217290
##########
cpp/src/arrow/c/abi.h:
##########
@@ -319,6 +319,11 @@ struct ArrowAsyncProducer {
// on_error callback on the async stream handler.
void (*cancel)(struct ArrowAsyncProducer* self);
+ // Any additional metadata tied to a specific stream of data. This must
either be NULL
+ // or a valid pointer to metadata which is encoded in the same way schema
metadata
+ // would be. Non-null metadata must be valid for the lifetime of this object.
Review Comment:
nit: can we keep the context about what kind of metadata might be useful to
pass, and the encoding of the string?
##########
cpp/src/arrow/c/abi.h:
##########
@@ -319,6 +319,11 @@ struct ArrowAsyncProducer {
// on_error callback on the async stream handler.
void (*cancel)(struct ArrowAsyncProducer* self);
+ // Any additional metadata tied to a specific stream of data. This must
either be NULL
+ // or a valid pointer to metadata which is encoded in the same way schema
metadata
+ // would be. Non-null metadata must be valid for the lifetime of this object.
Review Comment:
Also we should note it may only be valid after the schema callback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
