bkietz commented on code in PR #43632:
URL: https://github.com/apache/arrow/pull/43632#discussion_r1830334771
##########
cpp/src/arrow/c/abi.h:
##########
@@ -319,6 +319,11 @@ struct ArrowAsyncProducer {
// on_error callback on the async stream handler.
void (*cancel)(struct ArrowAsyncProducer* self);
+ // Any additional metadata tied to a specific stream of data. This must
either be NULL
+ // or a valid pointer to metadata which is encoded in the same way schema
metadata
+ // would be. Non-null metadata must be valid for the lifetime of this object.
Review Comment:
This entire struct is only valid after the schema callback, so noting that
again for just this field seems redundant. What kind of context are you
thinking of? An example like "a producer might use this to communicate the
total number of rows and/or batches in the stream if that is known? "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
