davidhcoe commented on code in PR #2312:
URL: https://github.com/apache/arrow-adbc/pull/2312#discussion_r1836830412
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -139,16 +144,21 @@ public class Options
// Options common to all HiveServer2Statement-derived drivers go
here
public const string PollTimeMilliseconds =
"adbc.statement.polltime_milliseconds";
Review Comment:
All of the options should be consistent across the namespaces. For this
driver, it might be a little different than others, but I would think something
like:
`adbc.apache.statement.polltime_milliseconds` if it is generic to all of the
drivers
`adbc.apache.spark.convert_float` if it is specific to one of the drivers. I
know the `adbc.spark[.convert_float]` has already been started, so that would
be fine to keep across the hive and impala drivers as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
