davidhcoe commented on code in PR #2312:
URL: https://github.com/apache/arrow-adbc/pull/2312#discussion_r1836822187
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs:
##########
@@ -90,6 +91,8 @@ internal async Task OpenAsync()
protected internal int HttpRequestTimeout { get; set; } = 30000;
+ protected internal int ConnectTimeout { get; set; } = 30000;
Review Comment:
There seem to be a mix of values here. QueryTimeoutDefault looks like
seconds, while HttpRequestTimeout, ConnectTimeout appear to be milliseconds.
Can we either add a comment or update the name (like
PollTimeMillisecondsDefault) to indicate the correct unit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
