emkornfield commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1855238747
##########
cpp/src/parquet/encoder.cc:
##########
@@ -181,7 +191,8 @@ inline void PlainEncoder<ByteArrayType>::Put(const
ByteArray* src, int num_value
}
template <typename ArrayType>
-void DirectPutImpl(const ::arrow::Array& values, ::arrow::BufferBuilder* sink)
{
+[[nodiscard]] int64_t DirectPutImpl(const ::arrow::Array& values,
Review Comment:
we don't have an abstracted macro for [[nodsiccard]]?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
