wgtmac commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1857663579
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -843,6 +843,14 @@ class BinaryMemoTable : public MemoTable {
}
}
+ // Visit the stored value at a specific index in insertion order.
+ // The visitor function should have the signature `void(std::string_view)`
Review Comment:
I agree that `const std::string_view&` is not recommended but I think it is
better to match the function `VisitValues` above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
