wgtmac commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1857677434
##########
cpp/src/parquet/encoder.cc:
##########
@@ -1604,6 +1654,7 @@ class RleBooleanEncoder final : public EncoderImpl,
virtual public BooleanEncode
},
[]() { return Status::OK(); }));
}
+ unencoded_data_bytes_ += sizeof(bool) * (values.length() -
values.null_count());
Review Comment:
Ah, I forgot to delete this line. (I was supposed to include boolean type
but it seems to be non-trivial to deal with input with `bool*`, `uint8_t*` and
`arrow::BooleanArray` so I removed changes of boolean types in the end)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
