wgtmac commented on code in PR #40594: URL: https://github.com/apache/arrow/pull/40594#discussion_r1857691684
########## cpp/src/parquet/column_writer.cc: ########## @@ -1421,6 +1454,8 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter< DictEncoder<DType>* current_dict_encoder_; std::shared_ptr<TypedStats> page_statistics_; std::shared_ptr<TypedStats> chunk_statistics_; + std::unique_ptr<SizeStatistics> page_size_statistics_; Review Comment: With regards to the comment at https://github.com/apache/arrow/pull/40594#discussion_r1856222399, I think it is much easier to use if `SizeStatistics::Make` returns an unique_ptr to match `std::shared_ptr<TypedStats>` above. ########## cpp/src/parquet/column_writer.cc: ########## @@ -1421,6 +1454,8 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter< DictEncoder<DType>* current_dict_encoder_; std::shared_ptr<TypedStats> page_statistics_; std::shared_ptr<TypedStats> chunk_statistics_; + std::unique_ptr<SizeStatistics> page_size_statistics_; Review Comment: With regards to the comment at https://github.com/apache/arrow/pull/40594#discussion_r1856222399, I think it is much easier to use if `SizeStatistics::Make` returns an unique_ptr to match `std::shared_ptr<TypedStats>` above. @pitrou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
