alamb commented on code in PR #6873:
URL: https://github.com/apache/arrow-rs/pull/6873#discussion_r1882194333
##########
arrow-ipc/src/writer.rs:
##########
@@ -65,6 +65,10 @@ pub struct IpcWriteOptions {
/// schema or generate unique dictionary IDs internally during encoding.
///
/// Defaults to `false`
+ #[deprecated(
Review Comment:
💯
##########
arrow-schema/src/field.rs:
##########
@@ -38,6 +38,10 @@ pub struct Field {
name: String,
data_type: DataType,
nullable: bool,
+ #[deprecated(
+ since = "54.0.0",
+ note = "The ability to preserve dictionary IDs will be removed. With
it, all fields related to it."
+ )]
dict_id: i64,
dict_is_ordered: bool,
Review Comment:
I wonder if we should deprecate dict_is_ordered as well 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
