brancz commented on PR #6873: URL: https://github.com/apache/arrow-rs/pull/6873#issuecomment-2543118067
> I think the existing tests that are currently relying on allow(deprecated) would be a good starting point I think we need to be a bit more specific, because how does this make sense for any of the `new_dict` calls? Practically none of the instances where `new_dict` is called is the dictionary ID actually relevant but it just happens to be part of the function signature. If I'm understanding you right though, you mean all the tests where the dictionary IDs value actually matters, right? Regarding still having another ability to set dict IDs: We can introduce a new option on `IpcWriteOptions` where the DictionaryTracker can be pre-set. And then we allow a dictionary tracker to be instantiated with a pre-populated list of dict IDs. Then a user could pre-populate the IDs, so we would have a second way of setting dict IDs that will still exist when the field doesn't exist anymore. I'll put it together and we can discuss more (really want to make this work because `dict_id` being on the Field is causing a ton of problems for us regarding equality for merging schemas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
