alamb commented on PR #6873: URL: https://github.com/apache/arrow-rs/pull/6873#issuecomment-2543899030
> Ok so is the thesis that dictionary ID are just an implementation detail of the IPC format, if so then I guess this is fine, and we can effectively use the deprecation as a scream test. I'm a little wary we are removing functionality here, but I'm also very out of the loop w.r.t the dictionary tracker changes. If Andrew is happy feel free to ignore me. Given that this PR deprecates the APIs and doesn't remove them and no one seems to have come up with any reasonable usecase for the current dict_id encoding (despite some clearly non trivial analysis by @brancz 🙏 and @thinkharderdev ) I think this PR cuts a nice balance between: 1. a real path for removing dict_ids 2. Not causing immense downstream pain by removing an API that is needed Let's merge this and see if anyone comes up with a motiviating usecase. Thank you again for sticking with this @brancz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org