ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r597968134



##########
File path: r/R/array.R
##########
@@ -291,3 +299,11 @@ is.Array <- function(x, type = NULL) {
   }
   is_it
 }
+
+#' @export
+sort.Array <- function(x, decreasing = FALSE, na.last = TRUE, ...) {
+  if (!identical(na.last, TRUE)) {
+    stop("Arrow only supports sort() with na.last = TRUE", call. = FALSE)

Review comment:
       I can work around it in R. I'll create a C++ JIRA too because 
controlling where missing values sort is common across different languages 
(e.g. `na_position` in pandas and `NULLS FIRST` and `NULLS LAST` in SQL)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to