nealrichardson commented on a change in pull request #9745: URL: https://github.com/apache/arrow/pull/9745#discussion_r597968473
########## File path: r/R/array.R ########## @@ -131,6 +133,12 @@ Array <- R6Class("Array", assert_is(i, "Array") call_function("filter", self, i, options = list(keep_na = keep_na)) }, + SortIndices = function(descending = FALSE) { Review comment: Fair point that they go together in that header, but that might mean that Take and Filter don't need to be R6 methods either. Historically, Take and Filter required different handling for Array vs. ChunkedArray etc., but now that the `call_function` interface exists, that's not the case, and in fact the C++ interface is functional rather than methods-based in that sense. Anyway, something to think about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org