birschick-bq commented on code in PR #2365:
URL: https://github.com/apache/arrow-adbc/pull/2365#discussion_r1924421301


##########
csharp/test/Drivers/Apache/Common/ComplexTypesValueTests.cs:
##########
@@ -28,7 +28,7 @@ namespace Apache.Arrow.Adbc.Tests.Drivers.Apache.Common
     /// <summary>
     /// Validates that specific complex structured types can be inserted, 
retrieved and targeted correctly
     /// </summary>
-    public class ComplexTypesValueTests<TConfig, TEnv> : TestBase<TConfig, 
TEnv>
+    public abstract class ComplexTypesValueTests<TConfig, TEnv> : 
TestBase<TConfig, TEnv>

Review Comment:
   This is being inherited by the Spark tests. Without `abstract`, it will be 
added to the tests. but it won't work because it doesn't have a concrete 
constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to