kushaman commented on code in PR #2365:
URL: https://github.com/apache/arrow-adbc/pull/2365#discussion_r1930879331
##########
csharp/test/Drivers/Apache/Common/NumericValueTests.cs:
##########
@@ -227,10 +228,7 @@ public async Task TestRoundingNumbers(decimal input,
decimal output)
[InlineData(1.234E+2)]
[InlineData(double.NegativeInfinity)]
[InlineData(double.PositiveInfinity)]
- [InlineData(double.NaN)]
- [InlineData(double.MinValue)]
- [InlineData(double.MaxValue)]
- public async Task TestDoubleValuesInsertSelectDelete(double value)
+ public virtual async Task TestDoubleValuesInsertSelectDelete(double
value)
Review Comment:
Added the follow up item for this
https://github.com/apache/arrow-adbc/issues/2488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
