davidhcoe commented on code in PR #2365:
URL: https://github.com/apache/arrow-adbc/pull/2365#discussion_r1927799280
##########
csharp/src/Drivers/Apache/Impala/ImpalaDatabase.cs:
##########
@@ -15,22 +15,29 @@
* limitations under the License.
*/
+using System;
using System.Collections.Generic;
+using System.Linq;
namespace Apache.Arrow.Adbc.Drivers.Apache.Impala
{
public class ImpalaDatabase : AdbcDatabase
{
readonly IReadOnlyDictionary<string, string> properties;
- internal ImpalaDatabase(IReadOnlyDictionary<string, string> properties)
+ public ImpalaDatabase(IReadOnlyDictionary<string, string> properties)
{
this.properties = properties;
}
- public override AdbcConnection Connect(IReadOnlyDictionary<string,
string>? properties)
+ public override AdbcConnection Connect(IReadOnlyDictionary<string,
string>? options)
{
- ImpalaConnection connection = new
ImpalaConnection(this.properties);
+ IReadOnlyDictionary<string, string> mergedProperties = options ==
null
Review Comment:
I thought I answered this before ... but, you are correct @CurtHagenlocher.
The C# BigQuery driver is a good example of separating these and then passing
on certain values to the statement object if need be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
