birschick-bq commented on code in PR #2365:
URL: https://github.com/apache/arrow-adbc/pull/2365#discussion_r1930832631
##########
csharp/test/Drivers/Apache/Common/StringValueTests.cs:
##########
@@ -90,15 +91,15 @@ await ValidateInsertSelectDeleteSingleValueAsync(
[SkippableTheory]
[InlineData(null)]
[InlineData("")]
- [InlineData("你好")]
[InlineData(" Leading and trailing spaces ")]
- protected virtual async Task TestCharData(string? value)
+ internal virtual async Task TestCharData(string? value)
Review Comment:
I've refactored this so that `InlineData` / `MemberData` are now implemented
in the the concrete classes.
##########
csharp/test/Drivers/Apache/Impala/Resources/ImpalaData.sql:
##########
@@ -16,118 +16,122 @@
DROP TABLE IF EXISTS {ADBC_CATALOG}.{ADBC_DATASET}.{ADBC_TABLE};
+-- Note:
+-- Impala supports complext type (ARRAY, MAP, STRUCT), BUT,
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
