tustvold commented on PR #7170: URL: https://github.com/apache/arrow-rs/pull/7170#issuecomment-2675237609
> With the API surface you've provided for inserting new elements into Extensions, it would be impossible to insert items from a SessionConfig's extensions into the new Extensions described here and still be able to retrieve them by their original type. You could add DataFusion's entire Extensions bundle here, whilst you would have two indirections, it would be the least magical mechanism for doing this. That being said, I am increasingly of the opinion the ObjectStore trait is being overloaded for something it fundamentally is not designed to be, and I would be interested in your thoughts on #7171. It seems really odd to me that we need to extend the ObjectStore trait, a generic interface to object stores, to support propagating DF context through to an IOx subsystem. This screams to me of a missing / incorrect layer of abstraction. I wonder if instead IOx could be using a less generic trait, e.g. overriding AsyncFileReaderFactory, or similar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
