crepererum commented on PR #7170: URL: https://github.com/apache/arrow-rs/pull/7170#issuecomment-2684892760
> That being said, I wonder what you think of using [http::Extensions](https://docs.rs/http/latest/http/struct.Extensions.html) instead. > > This would lose debug support, and making `http` a required dependency, but would have the advantage of being a standard ecosystem abstraction, and would allow for a pretty compelling way to pass through any extensions to the HttpClient implementation (#7183) I think `http` is already a dependency (indirectly), so the dependency argument doesn't count. I could live w/ loosing debugging support TBH and in vein of #7183 I think this is the better / more standard interface. FWIW InfluxData already uses `http` extension interface to pass tracing contexts through `tower` service layers and into `tonic` service implementations. So I think that somewhat confirms that using a common interface might be good. I'll leave this PR open for now and rebase & adjust it after #7183 gets merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
