crepererum commented on code in PR #7170:
URL: https://github.com/apache/arrow-rs/pull/7170#discussion_r1973503866
##########
object_store/src/client/mod.rs:
##########
@@ -718,27 +718,40 @@ impl GetOptionsExt for HttpRequestBuilder {
fn with_get_options(mut self, options: GetOptions) -> Self {
use hyper::header::*;
- if let Some(range) = options.range {
+ let GetOptions {
+ if_match,
+ if_none_match,
+ if_modified_since,
+ if_unmodified_since,
+ range,
+ version: _,
+ head: _,
Review Comment:
I've decided to unpack the struct to make the forwarding here easier to
maintain (so new fields are not forgotten). However we seem to have missed
these two.
@tustvold is this a bug? Shouldn't we at least wire up `version`? And `head`
should probably change the method, but I'm not sure how much will break if we
do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
