tustvold commented on code in PR #7170:
URL: https://github.com/apache/arrow-rs/pull/7170#discussion_r1973535046
##########
object_store/src/client/mod.rs:
##########
@@ -718,27 +718,40 @@ impl GetOptionsExt for HttpRequestBuilder {
fn with_get_options(mut self, options: GetOptions) -> Self {
use hyper::header::*;
- if let Some(range) = options.range {
+ let GetOptions {
+ if_match,
+ if_none_match,
+ if_modified_since,
+ if_unmodified_since,
+ range,
+ version: _,
+ head: _,
Review Comment:
Version is object store specific what it means and so is handled that way,
head requests is likely historical.
I wouldn't object to finding a way to roll the logic into here, but it isn't
entirely straightforward to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
