frbvianna commented on code in PR #2558:
URL: https://github.com/apache/arrow-adbc/pull/2558#discussion_r1972646173
##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -170,19 +171,30 @@ func quoteTblName(name string) string {
return "\"" + strings.ReplaceAll(name, "\"", "\"\"") + "\""
}
+type DriverOption func(*gosnowflake.Config) error
+
+func WithTransporter(transporter http.RoundTripper) DriverOption {
+ return func(cfg *gosnowflake.Config) error {
+ cfg.Transporter = transporter
+ return nil
+ }
+}
+
type driverImpl struct {
driverbase.DriverImplBase
+
+ opts []DriverOption
}
// NewDriver creates a new Snowflake driver using the given Arrow allocator.
-func NewDriver(alloc memory.Allocator) adbc.Driver {
+func NewDriver(alloc memory.Allocator, opts ...DriverOption) adbc.Driver {
Review Comment:
@zeroshade @lidavidm I have changed the PR with the changes that we
discussed here. Appreciate it if you could take a new look :)
I wasn't very successful at executing the unit tests locally, hope to find
out if it's passing from the CI, looks like the workflows need to be approved.
Can you please add the milestone ADBC 17 to this PR as well?
edit: nevermind, looks like this was automatic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
